[Nepomuk] Review Request 108754: fileindexer: initialize objects in correct order

Edward Hades Toroshchin edward.hades at gmail.com
Sun Feb 3 17:13:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108754/
-----------------------------------------------------------

Review request for Nepomuk.


Description
-------

fileindexer: initialize objects in correct order

The IndexCleaner job created in IndexScheduler could complete before
m_eventMonitor is initialized, which leads to crash in slotCleaningDone.

fileindexer: fix taglib bitrate units

taglib uses kbit/s for the bitrate unit, whereas nfo:averageBitrate is
in bit/s.


Diffs
-----

  services/fileindexer/indexer/taglibextractor.cpp e6ba162a78ce2d7c1f22295226d1fdcc9b45ff3f 
  services/fileindexer/indexscheduler.cpp 9ab9a1c3be73cdee50aab0a5c4bb9e77ca36e069 

Diff: http://git.reviewboard.kde.org/r/108754/diff/


Testing
-------

Nepomuk file indexer runs without crash.


Thanks,

Edward Hades Toroshchin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130203/58a52f8d/attachment.html>


More information about the Nepomuk mailing list