[Nepomuk] Review Request 112134: Tests: robustify the sandbox

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112134/#review38142
-----------------------------------------------------------


Most of the changes are good, however I'm not sure this would work. You haven't modified the NepomukTestLibMacros.cmake.in file. It still calls runNepomukTest.sh, instead of running reallyRunNepomukTest.sh

Btw, this library should probably be exported so that other people can use it? Do you want to clean it up and actually install it?

- Vishesh Handa


On Aug. 17, 2013, 5:45 p.m., Simeon Bird wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112134/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 5:45 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Tests: robustify the sandbox
> 
> Running the nepomuk tests always timed out for me. I found that this was
> because the nepomukserver was failing to start. There are two problems
> here:
> 
> 1) if the sandbox fails to start, it should just fail, not
> timeout.
> 
> 2) nepomukserver should not fail to start.
> 
> This patch fixes 1) by adding return value checking to the sandbox
> script; if kdeinit4 & friends fail to start the test fails instantly
> 
> 2) turned out to be because the nepomukserver could not
> connect to the (local) X server. To fix this, I changed the script to be
> started through xvfb-run, which starts a virtual X server for it to
> connect to.
> 
> Finally, start the nepomukserver we just built, rather than the
> installed one.
> 
> 
> Diffs
> -----
> 
>   autotests/lib/tools/runNepomukTest.sh.in 2eac3659043e47ebdaa8555061e6a8bbbea98511 
>   autotests/lib/tools/reallyRunNepomukTest.sh.in PRE-CREATION 
>   autotests/lib/tools/nepomuk-sandbox-end.sh.in e331cb04cce444ab582de9f3f731821792b116f3 
>   autotests/lib/tools/nepomuk-sandbox-begin.sh.in 1517dc99cd7c4247eb4e328100a4d3100979e563 
>   autotests/lib/tools/CMakeLists.txt 2e249628cbe161a059887dc231184aa82e1bc6a4 
> 
> Diff: http://git.reviewboard.kde.org/r/112134/diff/
> 
> 
> Testing
> -------
> 
> Only impacts tests. Makes them not timeout for me
> 
> 
> Thanks,
> 
> Simeon Bird
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130819/0da09c00/attachment.html>