[Nepomuk] Review Request 110050: Add button to Nepomuk KCM to clear file index

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110050/#review31177
-----------------------------------------------------------



nepomuk/kcm/nepomukconfigwidget.ui
<http://git.reviewboard.kde.org/r/110050/#comment23190>

    nitpick. Loose this



nepomuk/kcm/nepomukconfigwidget.ui
<http://git.reviewboard.kde.org/r/110050/#comment23191>

    Is this required?



nepomuk/kcm/nepomukserverkcm.h
<http://git.reviewboard.kde.org/r/110050/#comment23192>

    Please rename to slotClearIndexedData



nepomuk/kcm/nepomukserverkcm.cpp
<http://git.reviewboard.kde.org/r/110050/#comment23193>

    the component name in th KCM is never going to be "nepomukindexer". There is no need for this check.


- Vishesh Handa


On April 16, 2013, 8:09 p.m., Matthew McKeen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110050/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 8:09 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Simple patch to add a button to the advanced tab of the Nepomuk KCM into order to clear file index using Nepomuk2::removeDataByApplication()
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/nepomukconfigwidget.ui 88a7f56 
>   nepomuk/kcm/nepomukserverkcm.h 7bfee3c 
>   nepomuk/kcm/nepomukserverkcm.cpp 7cd5fbe 
> 
> Diff: http://git.reviewboard.kde.org/r/110050/diff/
> 
> 
> Testing
> -------
> 
> Testing done and works.
> 
> Kind of hard to see results because of Nepomuk caching, and since delete operations are delayed in the database after return of the remove function.
> 
> Working fine as far as I can tell.
> 
> 
> Thanks,
> 
> Matthew McKeen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130416/64c1d320/attachment-0001.html>