[Nepomuk] Review Request: In Nepomuk2::ResourceData, don't ignore return values from load()
Commit Hook
null at kde.org
Fri Sep 28 13:13:58 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106621/#review19514
-----------------------------------------------------------
This review has been submitted with commit c2dd5b811d3266b978cdd1df4d1e434cb44545df by Allen Winter to branch master.
- Commit Hook
On Sept. 28, 2012, 12:50 p.m., Allen Winter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106621/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2012, 12:50 p.m.)
>
>
> Review request for Nepomuk.
>
>
> Description
> -------
>
> Nepomuk2::ResourceData::load() returns a boolean success/failure. But several of the methods calling load() ignore that return value. This patch remedies that by checking the return from load() and dealing with it properly.
>
>
> Diffs
> -----
>
> libnepomukcore/resource/resourcedata.cpp c14582f
>
> Diff: http://git.reviewboard.kde.org/r/106621/diff/
>
>
> Testing
> -------
>
> Builds ok.
> Been running with it for a couple days with no crashes or obvious problems.
>
>
> Thanks,
>
> Allen Winter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120928/7189f80f/attachment.html>
More information about the Nepomuk
mailing list