[Nepomuk] Review Request: In Nepomuk2::ResourceData, don't ignore return values from load()

[Vishesh Handa]

> On Sept. 28, 2012, 12:59 p.m., Vishesh Handa wrote:
> > The patch still doesn't show over here, but I downloaded the patch and it seems fine.

Btw, Did you ever encounter a situation when load() was failing?


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106621/#review19511
-----------------------------------------------------------


On Sept. 28, 2012, 12:50 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106621/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 12:50 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Nepomuk2::ResourceData::load() returns a boolean success/failure.  But several of the methods calling load() ignore that return value.  This patch remedies that by checking the return from load() and dealing with it properly.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/resourcedata.cpp c14582f 
> 
> Diff: http://git.reviewboard.kde.org/r/106621/diff/
> 
> 
> Testing
> -------
> 
> Builds ok.
> Been running with it for a couple days with no crashes or obvious problems.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120928/1614fef1/attachment-0001.html>