[Nepomuk] Review Request: Soprano: Combine Server and Client streams into a new DataStream class
Vishesh Handa
me at vhanda.in
Tue Sep 25 14:56:36 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106568/
-----------------------------------------------------------
Review request for Nepomuk, Soprano and Sebastian Trueg.
Description
-------
Combine Server and Client streams into a new DataStream class
Instead of both the server and the client implementing their own
streaming operators. We combine all the streaming operators into a new
public class called Soprano::DataStream.
The Server and Client create their own respective class -
ServerDataStream and SocketStream respectively. The just have to
implement a read and write function.
This serves to eliminate code duplication, and allows others to use the
DataStream class, if they need it.
Diffs
-----
client/CMakeLists.txt 4e73e3c
client/socketstream.h a7b1eb2
client/socketstream.cpp 36472f1
server/CMakeLists.txt 8155648
server/datastream.h 0ecf2d3
server/datastream.cpp f98ee2d
server/serverconnection.cpp 786f9df
server/serverdatastream.h PRE-CREATION
server/serverdatastream.cpp PRE-CREATION
soprano/CMakeLists.txt 28c3188
soprano/datastream.h PRE-CREATION
soprano/datastream.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/106568/diff/
Testing
-------
Thanks,
Vishesh Handa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120925/76fce400/attachment.html>
More information about the Nepomuk
mailing list