[Nepomuk] Review Request: change export from per class to per method

[Vishesh Handa]

> On Aug. 1, 2012, 9:20 a.m., Vishesh Handa wrote:
> > It looks very ugly, but we can't help it. Please commit to KDE/4.9

Ping? Could you please commit this.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105767/#review16741
-----------------------------------------------------------


On July 28, 2012, 12:22 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105767/
> -----------------------------------------------------------
> 
> (Updated July 28, 2012, 12:22 p.m.)
> 
> 
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> The problem this fix solves is that SyncResource derives from QMultiHash<...>. QMultiHash is a template class which normally cannot export functions, except for type independent ones (e.g. non-template methodsd). Since QMultiHash or some base class of it uses exports on some methods, one cannot export derived classes completely anymore, but one has to export each and every method. This is actually done in the attached patch.
> 
> 
> Diffs
> -----
> 
>   services/backupsync/lib/syncresource.h d19463c 
> 
> Diff: http://git.reviewboard.kde.org/r/105767/diff/
> 
> 
> Testing
> -------
> 
> on Windows only, please test on Linux!
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120924/10359e33/attachment.html>