[Nepomuk] Review Request: ResourceMerger: Optimize resolveUnMappedNode

[Vishesh Handa]

> On Sept. 19, 2012, 1:55 p.m., Sebastian Trueg wrote:
> > services/storage/resourcemerger.cpp, line 525
> > <http://git.reviewboard.kde.org/r/106492/diff/2/?file=86266#file86266line525>
> >
> >     Why the sql lang, can't you just use sparql without the "sparql" prefix in the query?

Cause this way I avoid the RMM and all the other models. It's a neat way of avoiding everything.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106492/#review19160
-----------------------------------------------------------


On Sept. 19, 2012, 12:08 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106492/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 12:08 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Only convert the node to n3 once. And insert the statements in one go,
>     thereby avoiding the extra conversion via Soprano::Node::resourceToN3( .. )
> 
> Yes, I know, it's micro optimization. But this piece of code is called a lot.
> 
> 
> Diffs
> -----
> 
>   services/storage/test/qtest_dms.cpp ce91843 
>   services/storage/test/resourcewatchertest.cpp 6a3941b 
>   services/storage/test/fakedatamanagementservice.cpp 991a4e7 
>   services/storage/test/qtest_dms.h 5d21e4f 
>   services/storage/test/datamanagementadaptortest.cpp 8ffae7d 
>   services/storage/test/datamanagementmodeltest.cpp fc97f4b 
>   services/storage/resourcemerger.cpp 1bc87ee 
> 
> Diff: http://git.reviewboard.kde.org/r/106492/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120919/4436051a/attachment.html>