[Nepomuk] Review Request: RemoveableMediaModel: Only convert the urls if a device is connected

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106505/#review19162
-----------------------------------------------------------


Do you have a more detailed callgrind analysis of the removable media model? Maybe we can optimize it after all. In the end it should only be some hash lookups and string replacement. That is nothing complicated. So if its slow the implementation might be bad.

- Sebastian Trueg


On Sept. 19, 2012, 11:53 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106505/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 11:53 a.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     When there are no removeable media connected we shouldn't have to pay
>     the extremely steep price of the RemoveableMediaModel.
> 
> 
> Diffs
> -----
> 
>   common/removablemediacache.h ed11f7d 
>   common/removablemediacache.cpp fcdec07 
>   services/storage/removablemediamodel.cpp d2be90a 
> 
> Diff: http://git.reviewboard.kde.org/r/106505/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120919/4a7010a5/attachment-0001.html>