[Nepomuk] Review Request: ResourceMerger: Optimize resolveUnMappedNode

Vishesh Handa me at vhanda.in
Wed Sep 19 12:08:19 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106492/
-----------------------------------------------------------

Review request for Nepomuk and Sebastian Trueg.


Description
-------

    Only convert the node to n3 once. And insert the statements in one go,
    thereby avoiding the extra conversion via Soprano::Node::resourceToN3( .. )

Yes, I know, it's micro optimization. But this piece of code is called a lot.


Diffs
-----

  services/storage/test/qtest_dms.cpp ce91843 
  services/storage/test/resourcewatchertest.cpp 6a3941b 
  services/storage/test/fakedatamanagementservice.cpp 991a4e7 
  services/storage/test/qtest_dms.h 5d21e4f 
  services/storage/test/datamanagementadaptortest.cpp 8ffae7d 
  services/storage/test/datamanagementmodeltest.cpp fc97f4b 
  services/storage/resourcemerger.cpp 1bc87ee 

Diff: http://git.reviewboard.kde.org/r/106492/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120919/0ae27a57/attachment.html>


More information about the Nepomuk mailing list