[Nepomuk] Review Request: DataManagement: Optimize findApplicationResource by using a cache

[Vishesh Handa]

> On Sept. 18, 2012, 8:04 a.m., Sebastian Trueg wrote:
> > services/storage/datamanagementmodel.cpp, line 198
> > <http://git.reviewboard.kde.org/r/106485/diff/2/?file=85801#file85801line198>
> >
> >     Why only 10 apps?

Well, I thought that they shouldn't be more than 10 applications using Nepomuk at one point.

Should I increase it? QCache default is 500.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106485/#review19095
-----------------------------------------------------------


On Sept. 17, 2012, 7:07 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106485/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 7:07 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Instead of querying each time, we can use a QCache and cache the
>     last 10 application resources.
> 
> 
> Diffs
> -----
> 
>   services/storage/datamanagementmodel.h cf708da 
>   services/storage/datamanagementmodel.cpp 4221a3c 
>   services/storage/test/datamanagementadaptortest.cpp 839255b 
>   services/storage/test/datamanagementmodeltest.cpp 62e2557 
>   services/storage/test/fakedatamanagementservice.cpp a864117 
>   services/storage/test/resourcewatchertest.cpp 860dcf1 
> 
> Diff: http://git.reviewboard.kde.org/r/106485/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120918/c0af687b/attachment-0001.html>