[Nepomuk] Review Request: DataManagement: Optimize findApplicationResource by using a cache

Vishesh Handa me at vhanda.in
Mon Sep 17 19:07:48 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106485/
-----------------------------------------------------------

(Updated Sept. 17, 2012, 7:07 p.m.)


Review request for Nepomuk and Sebastian Trueg.


Changes
-------

Fix the tests by adding a clearCache function.

I'm sad to say that I have wasted over 2 hours figuring out what was wrong :/


Description
-------

    Instead of querying each time, we can use a QCache and cache the
    last 10 application resources.


Diffs (updated)
-----

  services/storage/datamanagementmodel.h cf708da 
  services/storage/datamanagementmodel.cpp 4221a3c 
  services/storage/test/datamanagementadaptortest.cpp 839255b 
  services/storage/test/datamanagementmodeltest.cpp 62e2557 
  services/storage/test/fakedatamanagementservice.cpp a864117 
  services/storage/test/resourcewatchertest.cpp 860dcf1 

Diff: http://git.reviewboard.kde.org/r/106485/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120917/ee1dd364/attachment.html>


More information about the Nepomuk mailing list