[Nepomuk] Review Request: LiteralTerm to N3: Optimize by using a cache

[Vishesh Handa]

> On Sept. 17, 2012, 12:41 p.m., Sebastian Trueg wrote:
> > soprano/node.cpp, line 427
> > <http://git.reviewboard.kde.org/r/106471/diff/1/?file=85714#file85714line427>
> >
> >     Does not look thread-safe. Is it?

You're right. It's not thread safe [1]. I think putting a mutex in the createEscapeHash code should fix it. What do you think?

[1] http://blogs.msdn.com/b/oldnewthing/archive/2004/03/08/85901.aspx


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106471/#review19064
-----------------------------------------------------------


On Sept. 17, 2012, 9:50 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106471/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 9:50 a.m.)
> 
> 
> Review request for Nepomuk, Soprano and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Optimize the N3 conversion by escaping all the necessary characters in
>     one go, and by caching the QString version of the data type.
>     
>     They aren't that many data types, so this shouldn't take up too much
>     space.
> 
> 
> Diffs
> -----
> 
>   soprano/node.cpp 8ebbe0e 
> 
> Diff: http://git.reviewboard.kde.org/r/106471/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120917/d8ec950d/attachment.html>