[Nepomuk] Review Request: Virtuoso Backend: Minor optimizations when parsing datetimes

Sebastian Trueg sebastian at trueg.de
Mon Sep 17 12:42:05 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106473/#review19065
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Trueg


On Sept. 17, 2012, 9:56 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106473/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 9:56 a.m.)
> 
> 
> Review request for Nepomuk, Soprano and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Virtuoso Backend: Minor optimizations when parsing datetimes
>     
>     Instead of storing the type in a long QUrl, and converting it to its
>     equivilant QVarant::Type by a hash lookup, we can just directly store
>     the QVariant::Type
> 
> 
> Diffs
> -----
> 
>   backends/virtuoso/odbcqueryresult.cpp a4f2387 
> 
> Diff: http://git.reviewboard.kde.org/r/106473/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120917/2aa2d75c/attachment.html>


More information about the Nepomuk mailing list