[Nepomuk] Review Request: Virtuoso Backend: Remove fake boolean types

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106469/#review19061
-----------------------------------------------------------


How about backwards compatibility? Already existing values in Nepomuk for example will become unusable. In other words: this is a behavioural change which should only happen in a major release, shouldn't it?

- Sebastian Trueg


On Sept. 17, 2012, 9:40 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106469/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 9:40 a.m.)
> 
> 
> Review request for Nepomuk, Soprano and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     The checking of these fake boolean types seems to almost take as long
>     as the query execution ( Valgrind stats - Normal sized queries fetching
>     1-5 properties )
> 
> 
> Diffs
> -----
> 
>   backends/virtuoso/odbcqueryresult.cpp a4f2387 
>   backends/virtuoso/virtuosomodel.cpp 6633208 
>   backends/virtuoso/virtuosomodel_p.h 456d1ad 
>   backends/virtuoso/virtuosotools.h 5c9942d 
>   backends/virtuoso/virtuosotools.cpp e4a2da5 
> 
> Diff: http://git.reviewboard.kde.org/r/106469/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120917/5a9a503d/attachment.html>