[Nepomuk] Review Request: Dolphin Places: Only show file results in Nepomuk Queries

[Frank Reininghaus]

> On Aug. 30, 2012, 12:19 p.m., Commit Hook wrote:
> > This review has been submitted with commit efc8a382498f7cf1f3877714931be74dd2aa8b39 by Vishesh Handa to branch KDE/4.9.

For some odd reason, this commit is not in the KDE/4.9 branch (neither in my up-to-date clone nor in the git web interface), even though the message to kde-commits says that it is. Therefore, the commit is not in KDE 4.9.1 either. The push to the master branch seemed to work OK though.

I have no clue what went wrong, but maybe you can try again to push it to KDE/4.9, such that the fix would at least make it into KDE 4.9.2?


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106274/#review18282
-----------------------------------------------------------


On Aug. 30, 2012, 11:08 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106274/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2012, 11:08 a.m.)
> 
> 
> Review request for Dolphin and Nepomuk.
> 
> 
> Description
> -------
> 
>     Dolphin is a file manager, and shouldn't be concerned with non-file
>     resources like notes, contacts and other stuff.
>     
>     Use FileQuery instead of Query.
>     
>     This also results in a faster queries. With File Queries Nepomuk can
>     perform some internal optimizations.
> 
> PS: I'd like to get this into 4.9.1, so a fast review would be nice. Also, do we cherry pick or merge KDE/4.9 into master?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp 4979013 
> 
> Diff: http://git.reviewboard.kde.org/r/106274/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120913/1bf1902e/attachment.html>