[Nepomuk] Review Request: Create a taskbar notification window when we run out of inotify watches

[Simeon Bird]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106748/
-----------------------------------------------------------

(Updated Oct. 11, 2012, 5:54 p.m.)


Review request for Nepomuk, KDE Usability, Vishesh Handa, and Sebastian Trueg.


Changes
-------

Added usability group to review


Description
-------

Currently, if we happen to run out of inotify watches in the filewatch service, all we get is a debug message, which is easily lost.
This patch additionally creates a popup notification to warn people they need to raise the limit.

I worried that a popup might be a bit too invasive - I considered also just logging to syslog, but that seemed not invasive enough. 
I figured that since metadata can get lost if the watches are not all installed, being fairly invasive is a good idea. 

What think you?


Diffs
-----

  services/filewatch/nepomukfilewatch.cpp 83045da 
  services/filewatch/nepomukfilewatch.notifyrc bfa88a9 

Diff: http://git.reviewboard.kde.org/r/106748/diff/


Testing
-------

> sudo sysctl fs.inotify.max_user_watches=10 
> killall nepomukserver && nepomukserver

Yup, there's a notification.


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121011/10af419b/attachment.html>