[Nepomuk] Review Request: Create a taskbar notification window when we run out of inotify watches
Vishesh Handa
me at vhanda.in
Thu Oct 11 12:22:20 UTC 2012
> On Oct. 8, 2012, 10:11 a.m., Vishesh Handa wrote:
> > services/filewatch/nepomukfilewatch.cpp, line 332
> > <http://git.reviewboard.kde.org/r/106748/diff/1/?file=88551#file88551line332>
> >
> > Maybe one would want to recommend an even higher limit?
> >
> > Also, "file changes will be ignored" seems a little scary. Maybe we could add the word indexing over there.
>
> Simeon Bird wrote:
> Ok. Maybe one could change 32768 to "NUM_DIRECTORIES"?
>
> Are you thinking "file changes will not be indexed"?
"file changes will not be indexed" sounds good.
Could you add the 'usability' group to the review? The more I think about this patch, the more I like it.
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106748/#review20063
-----------------------------------------------------------
On Oct. 6, 2012, 7:33 p.m., Simeon Bird wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106748/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2012, 7:33 p.m.)
>
>
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
>
>
> Description
> -------
>
> Currently, if we happen to run out of inotify watches in the filewatch service, all we get is a debug message, which is easily lost.
> This patch additionally creates a popup notification to warn people they need to raise the limit.
>
> I worried that a popup might be a bit too invasive - I considered also just logging to syslog, but that seemed not invasive enough.
> I figured that since metadata can get lost if the watches are not all installed, being fairly invasive is a good idea.
>
> What think you?
>
>
> Diffs
> -----
>
> services/filewatch/nepomukfilewatch.cpp 83045da
> services/filewatch/nepomukfilewatch.notifyrc bfa88a9
>
> Diff: http://git.reviewboard.kde.org/r/106748/diff/
>
>
> Testing
> -------
>
> > sudo sysctl fs.inotify.max_user_watches=10
> > killall nepomukserver && nepomukserver
>
> Yup, there's a notification.
>
>
> Thanks,
>
> Simeon Bird
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121011/bcb1f0f8/attachment.html>
More information about the Nepomuk
mailing list