[Nepomuk] Review Request: StoreResources: New flag - OverwriteAllProperties

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106770/#review20135
-----------------------------------------------------------

Ship it!


Sounds like a good addition. But keep my comments in mind.


libnepomukcore/datamanagement/datamanagement.h
<http://git.reviewboard.kde.org/r/106770/#comment15949>

    "anf" -> "and"



libnepomukcore/datamanagement/datamanagement.h
<http://git.reviewboard.kde.org/r/106770/#comment15950>

    while not a big problem here I suppose it would be better to always append new flags to keep the existing ones bw-compatible.


- Sebastian Trueg


On Oct. 8, 2012, 5:01 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106770/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 5:01 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     This allows to to use StoreResources as a convenient way to replace
>     large quantities of data into Nepomuk.
>     
>     This is especially useful for feeders such as telepathy that do not
>     follow the traditional - removeDataByApp + storeResources. It just uses
>     storeResources to update the few properties that usually change.
>     
>     In that case it makes it easier to just rely on storeResources.
> 
> This patch is on top of some 20 odd commits that completely refactor resourceMerger. Please just review if the flag is acceptable.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/datamanagement/datamanagement.h 2ac60a5 
>   services/storage/resourcemerger.cpp 64ad58b 
>   services/storage/test/datamanagementmodeltest.h ff606bc 
>   services/storage/test/datamanagementmodeltest.cpp 3d3340c 
> 
> Diff: http://git.reviewboard.kde.org/r/106770/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121010/63b765e8/attachment.html>