[Nepomuk] Review Request: StoreResources: Add a flag to force duplicate detection in the graph

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106711/#review20081
-----------------------------------------------------------


That's fine from the PIM side, but I'd still be interested where you'd want to avoid the duplicates merging. It seems like a crucial feature to me as soon as we have multiple applications operating on the same data, where we can't know which data is already present in the store and which isn't.
So it might make sense to change the semantics so you can disable the duplicates merging and have it on by default, as it seems to me more like a performance optimization for cases where we know that no duplicates are existing.
Otherwise we could render the whole database pretty quickly useless by creating a massive amount of duplicates.

Or am I just misunderstanding something?

- Christian Mollekopf


On Oct. 3, 2012, 12:11 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106711/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 12:11 p.m.)
> 
> 
> Review request for Nepomuk, Christian Mollekopf and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     StoreResources: Add a flag to force duplicate detection in the graph
>     
>     By default each SimpleResource in the graph was always hash (an
>     expensive process) and then checked for duplicates with the other
>     SimpleResources in the graph.
>     
>     This feature was only added cause the PIM guys were pushing large
>     quantities of duplicate data. It doesn't make sense for everyone to pay
>     the penalty for one application.
>     
>     They can enable this feature with the MergeDuplicateResources flag.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/datamanagement/datamanagement.h 2ac60a5 
>   services/storage/datamanagementmodel.cpp 7c05cfd 
>   services/storage/test/datamanagementmodeltest.cpp 3d3340c 
> 
> Diff: http://git.reviewboard.kde.org/r/106711/diff/
> 
> 
> Testing
> -------
> 
> Updated the relevant tests
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121008/ae493c9e/attachment.html>