[Nepomuk] Review Request: StoreResources: Add a flag to force duplicate detection in the graph
Sebastian Trueg
sebastian at trueg.de
Mon Oct 8 14:53:46 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106711/#review20078
-----------------------------------------------------------
libnepomukcore/datamanagement/datamanagement.h
<http://git.reviewboard.kde.org/r/106711/#comment15908>
better also describe what happens if it is not enabled.
services/storage/datamanagementmodel.cpp
<http://git.reviewboard.kde.org/r/106711/#comment15910>
This does change the default behaviour, right? Is that a problem?
- Sebastian Trueg
On Oct. 3, 2012, 12:11 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106711/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2012, 12:11 p.m.)
>
>
> Review request for Nepomuk, Christian Mollekopf and Sebastian Trueg.
>
>
> Description
> -------
>
> StoreResources: Add a flag to force duplicate detection in the graph
>
> By default each SimpleResource in the graph was always hash (an
> expensive process) and then checked for duplicates with the other
> SimpleResources in the graph.
>
> This feature was only added cause the PIM guys were pushing large
> quantities of duplicate data. It doesn't make sense for everyone to pay
> the penalty for one application.
>
> They can enable this feature with the MergeDuplicateResources flag.
>
>
> Diffs
> -----
>
> libnepomukcore/datamanagement/datamanagement.h 2ac60a5
> services/storage/datamanagementmodel.cpp 7c05cfd
> services/storage/test/datamanagementmodeltest.cpp 3d3340c
>
> Diff: http://git.reviewboard.kde.org/r/106711/diff/
>
>
> Testing
> -------
>
> Updated the relevant tests
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121008/3f59a9e4/attachment.html>
More information about the Nepomuk
mailing list