[Nepomuk] Review Request: ClassAndPropertyTree: Optimize variantListToNodeSet

Vishesh Handa me at vhanda.in
Fri Oct 5 15:56:53 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106740/
-----------------------------------------------------------

Review request for Nepomuk and Sebastian Trueg.


Description
-------

    The extra url comparsions take approximately 50% of the time spent in
    executing variantListToNodeSet. These comparisons are for special cases
    and are done based on the property.
    
    They can be done when the tree is being created, instead of each time
    this highly important function is called.
    
    * Caching the literal type - QVariant::Type
    * Special handling for xsd:duration
    * Special handling for rdfs:Literal


Diffs
-----

  services/storage/classandpropertytree.h 3e3174d 
  services/storage/classandpropertytree.cpp 1a337b4 

Diff: http://git.reviewboard.kde.org/r/106740/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121005/293bc618/attachment.html>


More information about the Nepomuk mailing list