[Nepomuk] Review Request: Nepomuk Runner: Port to Query::ResultIterator

Sebastian Trueg sebastian at trueg.de
Fri Oct 5 15:42:10 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106683/#review19974
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Trueg


On Oct. 2, 2012, 6:45 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106683/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 6:45 a.m.)
> 
> 
> Review request for Nepomuk, Plasma and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Instead of using the QueryServiceClient which uses dbus and spawns an
>     extra thread in the storage service, we use the ResultIterator which
>     uses a local socket to communicate.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/nepomuksearch/CMakeLists.txt c623b9f 
>   plasma/generic/runners/nepomuksearch/nepomuksearchrunner.h 267b05e 
>   plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp 1dbf0b9 
>   plasma/generic/runners/nepomuksearch/queryclientwrapper.h be5175b 
>   plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp 011c1a7 
> 
> Diff: http://git.reviewboard.kde.org/r/106683/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121005/b465b278/attachment.html>


More information about the Nepomuk mailing list