[Nepomuk] Review Request: Soprano: Combine Server and Client streams into a new DataStream class
Vishesh Handa
me at vhanda.in
Tue Oct 2 03:48:07 UTC 2012
> On Sept. 27, 2012, 12:08 p.m., David Faure wrote:
> > server/serverdatastream.cpp, line 52
> > <http://git.reviewboard.kde.org/r/106568/diff/1/?file=87131#file87131line52>
> >
> > I think this line is wrong and should be removed.
> > See my fix 418ee0f194564e8734d0f06656316bbbd9623685
> >
> > (and the cleanup of the commented out code in 439ae852647ca56f961eefcad6354c7c319eaeb0)
> >
> > both in soprano.git
Noted. I rather not do it in this patch, as I'm just splitting the code up.
I'll try to fix this up after I've committed this.
@Sebastian: Ping?
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106568/#review19494
-----------------------------------------------------------
On Sept. 25, 2012, 2:56 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106568/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2012, 2:56 p.m.)
>
>
> Review request for Nepomuk, Soprano and Sebastian Trueg.
>
>
> Description
> -------
>
> Combine Server and Client streams into a new DataStream class
>
> Instead of both the server and the client implementing their own
> streaming operators. We combine all the streaming operators into a new
> public class called Soprano::DataStream.
>
> The Server and Client create their own respective class -
> ServerDataStream and SocketStream respectively. The just have to
> implement a read and write function.
>
> This serves to eliminate code duplication, and allows others to use the
> DataStream class, if they need it.
>
>
> Diffs
> -----
>
> client/CMakeLists.txt 4e73e3c
> client/socketstream.h a7b1eb2
> client/socketstream.cpp 36472f1
> server/CMakeLists.txt 8155648
> server/datastream.h 0ecf2d3
> server/datastream.cpp f98ee2d
> server/serverconnection.cpp 786f9df
> server/serverdatastream.h PRE-CREATION
> server/serverdatastream.cpp PRE-CREATION
> soprano/CMakeLists.txt 28c3188
> soprano/datastream.h PRE-CREATION
> soprano/datastream.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/106568/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121002/21b98a65/attachment-0001.html>
More information about the Nepomuk
mailing list