[Nepomuk] Review Request: Resource: Avoid creating temporary Resources in ResourceData

David Faure faure at kde.org
Mon Oct 1 17:22:02 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106674/#review19706
-----------------------------------------------------------

Ship it!


Thanks, exactly what I had in mind.

- David Faure


On Oct. 1, 2012, 5:14 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106674/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 5:14 p.m.)
> 
> 
> Review request for Nepomuk, David Faure and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     This is done by adding properties of the form addResource/removeResource
>     (url) in the Resource Watcher.
>     
>     This fixes a possibile infinite loop in ResourceData::resetAll where a
>     temporary Resource is created which is again reset on deletion ..
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/datamanagement/resourcewatcher.h 14a5b83 
>   libnepomukcore/datamanagement/resourcewatcher.cpp c7d3359 
>   libnepomukcore/resource/resourcedata.cpp 58089ca 
> 
> Diff: http://git.reviewboard.kde.org/r/106674/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121001/75fbe881/attachment.html>


More information about the Nepomuk mailing list