[Nepomuk] Review Request: NepomukMainModel: Never reset the localSocketModel

Vishesh Handa me at vhanda.in
Fri Nov 30 13:54:06 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107533/
-----------------------------------------------------------

Review request for Nepomuk and Sebastian Trueg.


Description
-------

    NepomukMainModel: Never reset the localSocketModel
    
    We now never create a new LocalSocketModel on reconnecting. Instead we
    continue using the old one. This way we do not leak memory, as we could
    not delete the old model (open iterators).
    
    This is only possibly cause of the recent changes in Soprano which never
    delete the inner ClientConnection which is shared between the model and
    the LocalSocketClient. Before that commit the ClientConnection was
    deleted which would result in the old model becoming invalid.

This depends on https://git.reviewboard.kde.org/r/107531/


Diffs
-----

  libnepomukcore/resource/nepomukmainmodel.cpp 76bd6a3 

Diff: http://git.reviewboard.kde.org/r/107533/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121130/874051ca/attachment.html>


More information about the Nepomuk mailing list