[Nepomuk] Review Request: Improve nepomukcontroller UI

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107516/#review22770
-----------------------------------------------------------

Ship it!


Looks so much better! You rock!

- Vishesh Handa


On Nov. 29, 2012, 4:10 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107516/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 4:10 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> This patch prettifies Nepomuk StatusWidget. I made the following changes:
> 
> - Reorganize the widget content so that status text won't be cropped anymore. Set the label of the status text to wordwrap to ensure it is never truncated.
> 
> - Remove the bold on index count. Reason: it looks too big IMO.
> 
> - Get rid of KTitleWidget, replace it with a label and a bigger icon. Reason: it looks weird because the left of its text is not aligned with the other text below it.
> 
> Changes do not introduce any new strings, as can be seen in the screenshots (fully french translated)
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/statuswidget.cpp a5b7ae8 
>   nepomuk/kcm/statuswidget.ui c518300 
> 
> Diff: http://git.reviewboard.kde.org/r/107516/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> before-after
>   http://git.reviewboard.kde.org/r/107516/s/860/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121129/11dc9f43/attachment-0001.html>