[Nepomuk] Nepomuk Tags kioslave - Please Review

David Faure faure+bluesystems at kde.org
Thu Nov 22 09:27:41 UTC 2012


On Thursday 22 November 2012 00:24:12 Albert Astals Cid wrote:
> El Dimecres, 21 de novembre de 2012, a les 16:15:01, David Faure va 
escriure:
> > On Wednesday 07 November 2012 02:27:17 Albert Astals Cid wrote:
> > > Ahh, you mean copying from file: to tags:
> > Moving from file: to tags:, rather.
> 
> Right
> 
> > > I see... I'd like to hear David's opinion on how that is going to be
> > > fixed
> > > at  the kio/kioslave level.
> > 
> > Not at that level. Apps should be able to call move and end up with a
> > move.
> 
> Even if that means destroying the file into hyperspace?

Well, kioslaves were meant to be V*FS*. A file system doesn't lose files into 
hyperspace :)

However we already have a number of settings for "this or that functionality 
isn't supported by this kioslave". Hmm, I wonder, what does tags:/ do in 
put()? Where does it "write the file", if it's only a virtual collection of 
stuff?

If put() isn't supported, then moving (by get+put) won't be supported.
Only copyFromFile would be possible, which is exactly what you need, isn't it?

In other words, try not implementing put, if that makes sense, and let me know 
what doesn't work.

> > But the fix is to let drag-n-drop trigger a copy rather than allowing the
> > user to select "move". The quick fix for that is
> > http://www.davidfaure.fr/2012/konq_operations.cpp.diff
> > Which hardcodes the protocol name, but at least it gets the job done.
> > 
> > If we agree about this on principle, then the next step to make it generic
> > could be to add another field in .protocol files, say
> > forceDropAction=(copy|move)
> > The fact that kio_trash needs forceDropAction=move shows that this might
> > make sense, we already have two users for this setting.
> 
> I guess that works for me, since apps won't probably ever call "move" into a
> tags: url

OK. But let's keep this solution under the arm for now, until we find out about 
put() above.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by BlueSystems and KDAB to work on KDE Frameworks



More information about the Nepomuk mailing list