[Nepomuk] Review Request: Fix possibility of infinite loop

Simeon Bird bladud at gmail.com
Wed Nov 14 04:19:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107318/
-----------------------------------------------------------

Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.


Description
-------

Do not loop forever if there is an error executing the
 query in createUri (for example, the connection to the
 server died). Instead just return an empty url.

Also check for such an error with createGraph in ResourceMerger::merge.

This fixes a bug sort of introduced by b54cbaa5e00c1191cd2e66399aeb86a04ba85ef1.
If something went wrong with virtuoso, xsession-errors would fill up the
available space, because each loop called executeQuery and added an error message to the log.


Diffs
-----

  services/storage/datamanagementmodel.cpp 0a68513 
  services/storage/resourcemerger.cpp 41d6548 

Diff: http://git.reviewboard.kde.org/r/107318/diff/


Testing
-------

The usual


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121114/dd545e8b/attachment.html>


More information about the Nepomuk mailing list