[Nepomuk] Review Request: Make taglibextractor index flac and ogg files.

Vishesh Handa me at vhanda.in
Mon Nov 12 05:48:28 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107294/#review21859
-----------------------------------------------------------

Ship it!


Thanks :)

- Vishesh Handa


On Nov. 11, 2012, 5:46 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107294/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2012, 5:46 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Currently taglibextractor handles only mp3 files, but there shouldn't be any reason not to also index flac and ogg files.
> 
> 
> This addresses bug 309108.
>     http://bugs.kde.org/show_bug.cgi?id=309108
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/taglibextractor.cpp e908365 
> 
> Diff: http://git.reviewboard.kde.org/r/107294/diff/
> 
> 
> Testing
> -------
> 
> Taglibextractor correctly indexes flac and ogg files
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121112/ed40ac77/attachment.html>


More information about the Nepomuk mailing list