[Nepomuk] Review Request: Fix kactivities' check for the nepomuk resourcemanager

Simeon Bird bladud at gmail.com
Sun Nov 11 04:25:29 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107290/
-----------------------------------------------------------

Review request for Nepomuk and Ivan Čukić.


Description
-------

Kactivities was checking whether nepomuk was available by watching for
ownership of its dbus service. However, the dbus service may appear
before the resourcemanager (which is what we want) is actually ready.
    
Instead use the signals from libnepomukcore to tell when nepomuk
is turned on or off, thus avoiding talking to nepomuk before it is ready
to reply.
    
This was part of triggering bug 295933. Fixing the bug fully also needs #107285 and #107283


This addresses bug 295933.
    http://bugs.kde.org/show_bug.cgi?id=295933


Diffs
-----

  src/service/NepomukActivityManager.h bc2f9e3 
  src/service/NepomukActivityManager.cpp e283e9f 

Diff: http://git.reviewboard.kde.org/r/107290/diff/


Testing
-------

With the other two patches, the bug is fixed.


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121111/6671ddd5/attachment.html>


More information about the Nepomuk mailing list