[Nepomuk] Review Request: Mark resourcemanager soprano socket as disconnected when nepomuk is shut down (nepomuk-core version)
Simeon Bird
bladud at gmail.com
Sun Nov 11 04:25:03 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107283/
-----------------------------------------------------------
Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
Description
-------
Manually disconnect the socket connection to nepomuk in the resourcemanager when
nepomuk is shut down.
This is needed because the Soprano method isConnected() does not
actually check whether the socket is connected or not,
merely whether it has been connected at some point in the past.
So if we do not disconnect, Nepomuk::MainModel::isValid() will falsely claim
that the connection is ready for data, causing problems
should anything try to use it.
#107285 is the same commit for kdelibs nepomuk instead of nepomuk-core nepomuk.
This addresses bug 295933.
http://bugs.kde.org/show_bug.cgi?id=295933
Diffs
-----
libnepomukcore/resource/nepomukmainmodel.h 0d564b3
libnepomukcore/resource/nepomukmainmodel.cpp d5cabed
libnepomukcore/resource/resourcemanager.cpp 66d9fcc
Diff: http://git.reviewboard.kde.org/r/107283/diff/
Testing
-------
Compiled, ran, checked that (with the corresponding commit to kdelibs, and a kactivities fix)
it did actually fix bug 295933.
Thanks,
Simeon Bird
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121111/0f21eff3/attachment-0001.html>
More information about the Nepomuk
mailing list