[Nepomuk] Review Request: Mark resourcemanager soprano socket as disconnected when nepomuk is shut down (kdelibs version)

Simeon Bird bladud at gmail.com
Sun Nov 11 04:24:36 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107285/
-----------------------------------------------------------

Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.


Description
-------

Manually disconnect the socket connection to nepomuk in the resourcemanager when
nepomuk is shut down. 
    
This is needed because the Soprano method isConnected() does not
actually check whether the socket is connected or not, 
merely whether it has been connected at some point in the past. 
So if we do not disconnect, Nepomuk::MainModel::isValid() will falsely claim 
that the connection is ready for data, causing problems 
should anything try to use it.

Same as #107283, but for kdelibs nepomuk instead of nepomuk-core nepomuk. 

Both are needed to actually fix the bug, even in 4.10, because kFileMetaDataWidget still 
depends on nepomuk from kdelibs, and thus dolphin still links to kdelibs nepomuk. 


This addresses bug 295933.
    http://bugs.kde.org/show_bug.cgi?id=295933


Diffs
-----

  nepomuk/core/nepomukmainmodel.h a08ba5c 
  nepomuk/core/nepomukmainmodel.cpp 3473dbc 
  nepomuk/core/resourcemanager.cpp b3a1c80 

Diff: http://git.reviewboard.kde.org/r/107285/diff/


Testing
-------

Same as 107283


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121111/34fbe423/attachment.html>


More information about the Nepomuk mailing list