[Nepomuk] Review Request: Add 'long' as reserved c++ keyword for the SimpleResource rcgen

Vishesh Handa me at vhanda.in
Thu Nov 8 09:51:11 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107251/#review21617
-----------------------------------------------------------

Ship it!


I don't think a review request was required.

- Vishesh Handa


On Nov. 8, 2012, 9:14 a.m., Jörg Ehrichs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107251/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2012, 9:14 a.m.)
> 
> 
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Without this fix invalid c++ classes are generated due to the
> http://www.w3.org/2003/01/geo/wgs84_pos#long property
> 
> 
> Diffs
> -----
> 
>   services/storage/rcgen/nepomuk-simpleresource-rcgen.py 02507e8e2c5ada6908fa33630dd0f7b3f70b0df9 
> 
> Diff: http://git.reviewboard.kde.org/r/107251/diff/
> 
> 
> Testing
> -------
> 
> Tested a local copy with the proposed fix for the Nepomuk-MetaData Extractor and it works fine
> 
> 
> Thanks,
> 
> Jörg Ehrichs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121108/58d75adb/attachment.html>


More information about the Nepomuk mailing list