[Nepomuk] Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

Vishesh Handa me at vhanda.in
Mon May 28 14:27:23 UTC 2012



> On May 27, 2012, 1:53 p.m., Vishesh Handa wrote:
> > Pretty cool!
> 
> Kai Uwe Broulik wrote:
>     I will delay pushing this as there are currently some things not working quite out (see https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/74726c0e050b8104591ae8544fe8f9bd07baed93) and I don’t want to interfere here or push changes without having them compiled again inbeforehand :)

You'll have to port them to Nepomuk2, which should get automatically done when you rebase. As for that commit, everything has now been fixed :)

Also, we are in some kind of freeze. This qualifies as a bug fix, right?


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102523/#review14203
-----------------------------------------------------------


On May 23, 2012, 3:25 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102523/
> -----------------------------------------------------------
> 
> (Updated May 23, 2012, 3:25 p.m.)
> 
> 
> Review request for KDE Runtime and Nepomuk.
> 
> 
> Description
> -------
> 
> This little patch adds a "Configure Desktop Search" button to the nepomukcontroller statuswidget (the little status dialog that appears if you left-click on the nepomuk tray icon).
> I know that you can access strigi configuration via the tray icon's context menu but I often found myself opening the status dialog and then wanting to get to the config dialog from there. Can't harm, can it? :)
> 
> I also added a pause/resume icon to the suspend/resume button.
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/statuswidget.h b7af01e 
>   nepomuk/kcm/statuswidget.cpp a9ece31 
>   nepomuk/kcm/statuswidget.ui ab210c8 
> 
> Diff: http://git.reviewboard.kde.org/r/102523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120528/0eeebfcd/attachment.html>


More information about the Nepomuk mailing list