[Nepomuk] Review Request: Signal the End of Ontology Loading on DBus

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104964/#review13880
-----------------------------------------------------------

Ship it!


Looks good. But we need a patch for nepomuk-core indeed. Be aware though that the code changed slightly in nepomuk-core. Thus, your patch does not apply 100%.

- Sebastian Trueg


On May 16, 2012, 2:29 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104964/
> -----------------------------------------------------------
> 
> (Updated May 16, 2012, 2:29 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Since ontologies are loaded asynchronously, the end of the loading process should be made available through DBus. I can provide the patch for Nepomuk Core too if needed.
> 
> 
> This addresses bug 298684.
>     http://bugs.kde.org/show_bug.cgi?id=298684
> 
> 
> Diffs
> -----
> 
>   nepomuk/interfaces/org.kde.nepomuk.OntologyManager.xml 8977b79 
>   nepomuk/services/storage/nepomukcore.cpp 116350c 
>   nepomuk/services/storage/ontologyloader.h 4e0ce26 
>   nepomuk/services/storage/ontologyloader.cpp c06a297 
> 
> Diff: http://git.reviewboard.kde.org/r/104964/diff/
> 
> 
> Testing
> -------
> 
> 1) Log into a session
> 2) Open a terminal and type
> 
> dbus-monitor "type='signal',interface='org.kde.nepomuk.OntologyManager',member='ontologyLoadingFinished'"
> 
> 3) Wait for the ontologies to finish loading, you should see dbus-monitor reporting the signal
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120516/31fa4814/attachment.html>