[Nepomuk] Review Request: Remove threading code from nepomuksearch kio slave

Commit Hook null at kde.org
Mon Jun 25 08:27:44 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105255/#review15098
-----------------------------------------------------------


This review has been submitted with commit 9fd1771f3f03de53a4c5ab47c3501a67a32a8fcb by Vishesh Handa to branch master.

- Commit Hook


On June 14, 2012, 11:28 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105255/
> -----------------------------------------------------------
> 
> (Updated June 14, 2012, 11:28 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> The extra QThread isn't really required and complicates the code, and also adds an unnecessary overhead.
> 
> 
> Diffs
> -----
> 
>   nepomuk/kioslaves/search/kio_nepomuksearch.h e68ff29 
>   nepomuk/kioslaves/search/kio_nepomuksearch.cpp 38894be 
>   nepomuk/kioslaves/search/searchfolder.h c0839b5 
>   nepomuk/kioslaves/search/searchfolder.cpp 8088c46 
> 
> Diff: http://git.reviewboard.kde.org/r/105255/diff/
> 
> 
> Testing
> -------
> 
> Works exactly the same as before.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120625/564cc8f1/attachment-0001.html>


More information about the Nepomuk mailing list