[Nepomuk] Review Request: ResourceManager: Do not double initalize the NepomukMainModel

Vishesh Handa me at vhanda.in
Mon Jun 25 08:16:05 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105281/
-----------------------------------------------------------

(Updated June 25, 2012, 8:16 a.m.)


Review request for Nepomuk and Sebastian Trueg.


Changes
-------

Removed init() from the mainModel constructor


Description
-------

ResourceManager: Do not double initalize the NepomukMainModel

The NepomukMainModel is initalized once when it is created and then the
second time in ResourceManager::init.

This results in a second connection being made to nepomukstorage, and an
extra thread being spawned over there. The old thread is eventually
deleted, but the whole process is rather pointless.


Diffs (updated)
-----

  libnepomukcore/resource/nepomukmainmodel.cpp a11faae9a6d42806ba884e74f07e2d0113c6910f 

Diff: http://git.reviewboard.kde.org/r/105281/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120625/6d5eaaf0/attachment.html>


More information about the Nepomuk mailing list