[Nepomuk] Review Request: Remove threading code from nepomuksearch kio slave

Vishesh Handa me at vhanda.in
Thu Jun 14 23:28:54 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105255/
-----------------------------------------------------------

Review request for Nepomuk and Sebastian Trueg.


Description
-------

The extra QThread isn't really required and complicates the code, and also adds an unnecessary overhead.


Diffs
-----

  nepomuk/kioslaves/search/kio_nepomuksearch.h e68ff29 
  nepomuk/kioslaves/search/kio_nepomuksearch.cpp 38894be 
  nepomuk/kioslaves/search/searchfolder.h c0839b5 
  nepomuk/kioslaves/search/searchfolder.cpp 8088c46 

Diff: http://git.reviewboard.kde.org/r/105255/diff/


Testing
-------

Works exactly the same as before.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120614/e7b50eba/attachment-0001.html>


More information about the Nepomuk mailing list