[Nepomuk] Review Request: Fix: non numeric genres in id3 v2 mp3 are ignored.
Sebastian Trueg
sebastian at trueg.de
Wed Jun 13 20:25:17 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105242/#review14705
-----------------------------------------------------------
lib/endanalyzers/id3endanalyzer.cpp
<http://git.reviewboard.kde.org/r/105242/#comment11611>
I think you mean "genre", not "gender". :)
lib/endanalyzers/id3endanalyzer.cpp
<http://git.reviewboard.kde.org/r/105242/#comment11612>
Would it make sense to check the value or is ot ok to just allow any string to be the genre?
- Sebastian Trueg
On June 13, 2012, 4:03 p.m., Ignacio Serantes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105242/
> -----------------------------------------------------------
>
> (Updated June 13, 2012, 4:03 p.m.)
>
>
> Review request for Nepomuk, Strigi and Vishesh Handa.
>
>
> Description
> -------
>
> If genre is stored in a non numeric format genre is not imported.
>
>
> Diffs
> -----
>
> lib/endanalyzers/id3endanalyzer.cpp d8487b5
>
> Diff: http://git.reviewboard.kde.org/r/105242/diff/
>
>
> Testing
> -------
>
> Testing with and without a genre in string form.
>
>
> Thanks,
>
> Ignacio Serantes
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120613/13c476f1/attachment-0001.html>
More information about the Nepomuk
mailing list