[Nepomuk] Review Request: Patch to fix bug 293111, which is about files in subfolders of nepomuksearch:// listings not opening correctly.

[Simeon Bird]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105158/
-----------------------------------------------------------

Review request for Dolphin, Nepomuk, Peter Penz, and Sebastian Trueg.


Summary (updated)
-----------------

Patch to fix bug 293111, which is about files in subfolders of nepomuksearch:// listings not opening correctly.


Description (updated)
-------

This patch attempts to fix bug 293111.

The problem is that the nepomuk kioslave gives files a targetUrl understandable by non-KDE applications (ie, their real path on the filesystem). 

However, it does not give this to directories, and it only does the fancy stuff on the query folder, not any subfolders. The subfolders are opened with the kioslave base listdir class. The easy way to fix this is to set UDS_TARGET_URL for director a "real" url, which is what the attached patch does. 


This addresses bug 293111.
    http://bugs.kde.org/show_bug.cgi?id=293111


Diffs (updated)
-----

  nepomuk/kioslaves/search/searchfolder.cpp 8088c46 

Diff: http://git.reviewboard.kde.org/r/105158/diff/


Testing (updated)
-------

I compiled and ran it on my machine with some search results. Not tested on search results that are not local files.


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120606/b3af3921/attachment.html>