[Nepomuk] Review Request: No qDebug output in non debug modes

[Vishesh Handa]

> On July 31, 2012, 5:57 p.m., David Faure wrote:
> > Looks good (except for the trailing whitespace).
> > 
> > Maybe you want to copy the stuff about CMAKE_CXX_FLAGS_DEBUGFULL too? (Makes it possible to use step-by-step in gdb)

This?

if(CMAKE_COMPILER_IS_GNUCXX OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang"))
   set(CMAKE_CXX_FLAGS_DEBUGFULL      "-g3 -fno-inline" CACHE STRING
       "Flags used by the C++ compiler during debugfull builds." FORCE)

   set(CMAKE_C_FLAGS_DEBUGFULL        "-g3 -fno-inline" CACHE STRING
       "Flags used by the C compiler during debugfull builds." FORCE)

   mark_as_advanced(CMAKE_CXX_FLAGS_DEBUGFULL CMAKE_C_FLAGS_DEBUGFULL)

   # Update the documentation string of CMAKE_BUILD_TYPE for ccache & cmake-gui
   set(CMAKE_BUILD_TYPE "${CMAKE_BUILD_TYPE}" CACHE STRING
       "Choose the type of build, options are: None debugfull Debug Release RelWithDebInfo MinSizeRel."
       FORCE)
endif()


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105807/#review16711
-----------------------------------------------------------


On July 31, 2012, 5:11 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105807/
> -----------------------------------------------------------
> 
> (Updated July 31, 2012, 5:11 p.m.)
> 
> 
> Review request for Nepomuk, Soprano, David Faure, and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Soprano should not emit debug output when compiling with Release or RelWithDebInfo.
> 
> The code is copied from Akonadi's CMakeLists.txt
> 
> 
> This addresses bug 247483.
>     http://bugs.kde.org/show_bug.cgi?id=247483
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cb26fb7 
> 
> Diff: http://git.reviewboard.kde.org/r/105807/diff/
> 
> 
> Testing
> -------
> 
> Yup. No debug statements in Release or RelWithDebInfo mode.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120731/42d68012/attachment.html>