[Nepomuk] Review Request: Delete the IndexSchduler before its thread quits

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105806/#review16708
-----------------------------------------------------------



services/fileindexer/fileindexer.cpp
<http://git.reviewboard.kde.org/r/105806/#comment13003>

    You do not delete the index scheduler before the thread quits here since you are deferring it to the event queue. Since the index scheduler lives in the thread you are about to quit the indexscheduler might not even be deleted at all... not sure, did you try to add a kdbebug to check?
    
    


- Sebastian Trueg


On July 31, 2012, 3:42 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105806/
> -----------------------------------------------------------
> 
> (Updated July 31, 2012, 3:42 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     The IndexScheduler lives in the m_schedulingThread, which should ideally
>     be deleted before the thread finishes execution.
> 
> 
> This addresses bug 301698.
>     http://bugs.kde.org/show_bug.cgi?id=301698
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/fileindexer.cpp af8be4d 
> 
> Diff: http://git.reviewboard.kde.org/r/105806/diff/
> 
> 
> Testing
> -------
> 
> Nope. Cannot test this. In fact I'm not even sure if this was actually the reason for the crash.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120731/dea49be3/attachment.html>