[Nepomuk] Review Request: Use nao:iconName for icons instead of nao:prefLabel

[Albert Astals Cid]

> On July 30, 2012, 6:07 p.m., Albert Astals Cid wrote:
> > What's the outcome for 4.9.0 if we do not get this in?
> 
> Vishesh Handa wrote:
>     Nothing drastic. Internal database stuff. Makes very little difference if it goes into 4.9 or 4.9.1 or 4.10.
>     
>     Nothing user visible. I currently handle both cases in the user interface.

If it does not make any huge difference, let's get it into 4.9.1 then, the less changes we made to pre-release tarballs the better (If you agree please mark this as submitted so it disappears from the release-team queue and commit it after we release on wednesday)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105744/#review16669
-----------------------------------------------------------


On July 27, 2012, 9:54 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105744/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 9:54 a.m.)
> 
> 
> Review request for Nepomuk, Release Team and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> The old icons will eventually be merged when I make the data migration
> application for Nepomuk.
> 
> This needs to go both in kdelibs and nepomuk-core.
> 
> 
> Diffs
> -----
> 
>   nepomuk/core/resource.cpp eba3cea 
> 
> Diff: http://git.reviewboard.kde.org/r/105744/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120730/0b990f95/attachment.html>