[Nepomuk] Review Request: Resouce: Properly implement genericIcon

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105745/
-----------------------------------------------------------

(Updated July 27, 2012, 3:31 p.m.)


Review request for Nepomuk and Sebastian Trueg.


Changes
-------

Prefer native symbols over mimetype.


Description
-------

    The old generic icon just used to look at the string present in
    nao:hasSymbol. However, that was incorrect as nao:hasSymbol has a range
    of nao:Symbol, and not of a string.
    
    This patch results in proper icons being shown in the Nepomuk KRunner,
    as it uses genericIcon to get the icon name.


Diffs (updated)
-----

  nepomuk/core/resource.cpp eba3cea 

Diff: http://git.reviewboard.kde.org/r/105745/diff/


Testing
-------

Tested manually.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120727/35618fb6/attachment.html>