[Nepomuk] Review Request: Remove the Thing class

Vishesh Handa me at vhanda.in
Fri Jul 27 14:37:12 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105755/
-----------------------------------------------------------

(Updated July 27, 2012, 2:37 p.m.)


Review request for Nepomuk, Release Team and Sebastian Trueg.


Changes
-------

@Release Team (Albert): Please please let me commit this. I hate old stupid code. I'll have to live with it until we release KDE frameworks, that could be years away! If you have to choose any one of my patches to allow - THIS is the one to choose. The bug fixes can always go in 4.9.1. This cannot!

Thanks


Description
-------

No one uses it, and the same class can be generated using the rcgen. 
I don't see the point of having this class.

This is my last chance to remove this old code. Otherwise I'll have to wait till KDE Frameworks 5.


Diffs
-----

  includes/CMakeLists.txt 4ac2d7c 
  includes/Thing 952544e 
  libnepomukcore/CMakeLists.txt 066c898 
  libnepomukcore/resource/thing.h 2ae3d75 
  libnepomukcore/resource/thing.cpp 59f2a4d 

Diff: http://git.reviewboard.kde.org/r/105755/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120727/633bfd9c/attachment.html>


More information about the Nepomuk mailing list