[Nepomuk] Review Request: Resouce: Properly implement genericIcon

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105745/#review16510
-----------------------------------------------------------



nepomuk/core/resource.cpp
<http://git.reviewboard.kde.org/r/105745/#comment12873>

    How about giving priority to manually set symbols over the mimetype symbol?



nepomuk/core/resource.cpp
<http://git.reviewboard.kde.org/r/105745/#comment12874>

    This is very nice. :)



nepomuk/core/resource.cpp
<http://git.reviewboard.kde.org/r/105745/#comment12872>

    I wrote a patch for that at some point but never merged it. IMHO this is a tricky issue since the cache does not include all inferred properties and probably should not.
    One possibility would be to add a parameter which allows to enabled inference for the property() method.


- Sebastian Trueg


On July 26, 2012, 8:44 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105745/
> -----------------------------------------------------------
> 
> (Updated July 26, 2012, 8:44 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     The old generic icon just used to look at the string present in
>     nao:hasSymbol. However, that was incorrect as nao:hasSymbol has a range
>     of nao:Symbol, and not of a string.
>     
>     This patch results in proper icons being shown in the Nepomuk KRunner,
>     as it uses genericIcon to get the icon name.
> 
> 
> Diffs
> -----
> 
>   nepomuk/core/resource.cpp eba3cea 
> 
> Diff: http://git.reviewboard.kde.org/r/105745/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120727/8489bd2c/attachment-0001.html>