[Nepomuk] Review Request: Move the SimpleResource tests to libnepomukcore

Vishesh Handa me at vhanda.in
Wed Jul 25 18:17:16 UTC 2012



> On July 25, 2012, 5:59 p.m., Sebastian Trueg wrote:
> > Actually they should be in a top-level dir rather than in subdirs. I think all tests should be in a "tests" folder - or something like that. Isn't that also what the K5 spec says?
> 
> Vishesh Handa wrote:
>     They say it should go in 'autotests'. We can the libnepomukcore tests over there, if you want.
>     
>     http://community.kde.org/Frameworks/Strategy_and_Policies#Framework_directory_structure
> 
> Sebastian Trueg wrote:
>     I do not really mind that much either way. I just figured: if you move them anyway, why not move them where KDE policy wants them?

Alright. I'll move all of them to autotests, but I'm not creating a review request for it.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105726/#review16384
-----------------------------------------------------------


On July 25, 2012, 11:55 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105726/
> -----------------------------------------------------------
> 
> (Updated July 25, 2012, 11:55 a.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> They do not belong in the storage service any more.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/test/CMakeLists.txt 4a6f9d8 
>   libnepomukcore/test/simpleresourceclassestest.h PRE-CREATION 
>   libnepomukcore/test/simpleresourceclassestest.cpp PRE-CREATION 
>   services/storage/test/CMakeLists.txt b668521 
>   services/storage/test/simpleresourceclassestest.h 8593427 
>   services/storage/test/simpleresourceclassestest.cpp da0e0e6 
> 
> Diff: http://git.reviewboard.kde.org/r/105726/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120725/0743730a/attachment.html>


More information about the Nepomuk mailing list