[Nepomuk] Review Request: ResourceWatcher: Convert uris to QUrls
Sebastian Trueg
sebastian at trueg.de
Wed Jul 25 18:07:42 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105710/#review16390
-----------------------------------------------------------
libnepomukcore/datamanagement/resourcewatcher.cpp
<http://git.reviewboard.kde.org/r/105710/#comment12837>
Actually it is sufficient to check prop.literalRangeType().isValid(). That avoids checking the hierarchy.
- Sebastian Trueg
On July 25, 2012, 12:42 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105710/
> -----------------------------------------------------------
>
> (Updated July 25, 2012, 12:42 p.m.)
>
>
> Review request for Nepomuk and Sebastian Trueg.
>
>
> Description
> -------
>
> uris are received as strings, but they should be saved as QUrls in the
> QVariant.
>
>
> Diffs
> -----
>
> libnepomukcore/datamanagement/resourcewatcher.cpp 0b08c73
>
> Diff: http://git.reviewboard.kde.org/r/105710/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120725/8048fd7b/attachment.html>
More information about the Nepomuk
mailing list