[Nepomuk] Review Request: Move the SimpleResource tests to libnepomukcore

Sebastian Trueg sebastian at trueg.de
Wed Jul 25 17:59:20 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105726/#review16384
-----------------------------------------------------------


Actually they should be in a top-level dir rather than in subdirs. I think all tests should be in a "tests" folder - or something like that. Isn't that also what the K5 spec says?

- Sebastian Trueg


On July 25, 2012, 11:55 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105726/
> -----------------------------------------------------------
> 
> (Updated July 25, 2012, 11:55 a.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> They do not belong in the storage service any more.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/test/CMakeLists.txt 4a6f9d8 
>   libnepomukcore/test/simpleresourceclassestest.h PRE-CREATION 
>   libnepomukcore/test/simpleresourceclassestest.cpp PRE-CREATION 
>   services/storage/test/CMakeLists.txt b668521 
>   services/storage/test/simpleresourceclassestest.h 8593427 
>   services/storage/test/simpleresourceclassestest.cpp da0e0e6 
> 
> Diff: http://git.reviewboard.kde.org/r/105726/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120725/d8f4e911/attachment.html>


More information about the Nepomuk mailing list